weixiuli commented on code in PR #7676:
URL: https://github.com/apache/incubator-gluten/pull/7676#discussion_r1831024513
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -216,15 +216,26 @@ object VeloxBackendSettings extends BackendSettingsApi {
// Validate if all types are supported.
def validateDataTypes(): Option[String] = {
- val unsupportedTypes = fields.flatMap {
- field =>
- field.dataType match {
- case _: StructType => Some("StructType")
- case _: ArrayType => Some("ArrayType")
- case _: MapType => Some("MapType")
- case _: YearMonthIntervalType => Some("YearMonthIntervalType")
+ val unsupportedTypes = format match {
+ case _: ParquetFileFormat =>
+ fields.flatMap {
+ case StructField(_, _: YearMonthIntervalType, _, _) =>
+ Some("YearMonthIntervalType")
+ case StructField(_, _: StructType, _, _) =>
Review Comment:
> @weixiuli Velox doesn't support struct(struct), right?
Whether or not a StructType is a constant, it is captured by the
validateDataTypes and does not support vectorized writes. The
`isConstantComplexType` method is used to check if ArrayType/MapType is
sconstant, and if it is, it needs to fall back because velox currently supports
this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
