JkSelf commented on code in PR #7676:
URL: https://github.com/apache/incubator-gluten/pull/7676#discussion_r1830888144
##########
gluten-ut/spark35/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetFieldIdIOSuite.scala:
##########
@@ -16,6 +16,27 @@
*/
package org.apache.spark.sql.execution.datasources.parquet
-import org.apache.spark.sql.GlutenSQLTestsBaseTrait
+import org.apache.spark.sql.{GlutenSQLTestsBaseTrait, Row}
-class GlutenParquetFieldIdIOSuite extends ParquetFieldIdIOSuite with
GlutenSQLTestsBaseTrait {}
+class GlutenParquetFieldIdIOSuite extends ParquetFieldIdIOSuite with
GlutenSQLTestsBaseTrait {
Review Comment:
@weixiuli Do we need to add this test for spark 32 33 and 34?
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/WriteFilesExecTransformer.scala:
##########
@@ -127,6 +131,37 @@ case class WriteFilesExecTransformer(
override protected def doValidateInternal(): ValidationResult = {
val finalChildOutput = getFinalChildOutput
+
+ def isConstantComplexType(e: Expression): Boolean = {
+ e match {
+ case Literal(_, _: ArrayType | _: MapType) => true
Review Comment:
@weixiuli Do we need StructType check here?
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -216,15 +216,26 @@ object VeloxBackendSettings extends BackendSettingsApi {
// Validate if all types are supported.
def validateDataTypes(): Option[String] = {
- val unsupportedTypes = fields.flatMap {
- field =>
- field.dataType match {
- case _: StructType => Some("StructType")
- case _: ArrayType => Some("ArrayType")
- case _: MapType => Some("MapType")
- case _: YearMonthIntervalType => Some("YearMonthIntervalType")
+ val unsupportedTypes = format match {
+ case _: ParquetFileFormat =>
+ fields.flatMap {
+ case StructField(_, _: YearMonthIntervalType, _, _) =>
+ Some("YearMonthIntervalType")
+ case StructField(_, _: StructType, _, _) =>
Review Comment:
@weixiuli Velox doesn't support struct(struct), right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
