weixiuli commented on code in PR #7676:
URL: https://github.com/apache/incubator-gluten/pull/7676#discussion_r1831039042
##########
gluten-ut/spark35/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetFieldIdIOSuite.scala:
##########
@@ -16,6 +16,27 @@
*/
package org.apache.spark.sql.execution.datasources.parquet
-import org.apache.spark.sql.GlutenSQLTestsBaseTrait
+import org.apache.spark.sql.{GlutenSQLTestsBaseTrait, Row}
-class GlutenParquetFieldIdIOSuite extends ParquetFieldIdIOSuite with
GlutenSQLTestsBaseTrait {}
+class GlutenParquetFieldIdIOSuite extends ParquetFieldIdIOSuite with
GlutenSQLTestsBaseTrait {
Review Comment:
> @weixiuli Do we need to add this test for spark 32 33 and 34?
Thanks, done. Add UT for 33 and 34, 32 doesn't have WriteFilesExec, so it
doesn't need to add. BTW, the existing unit tests in spark 32, 33, 34 ,35 also
can cover this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
