zhztheplayer commented on code in PR #8011:
URL: https://github.com/apache/incubator-gluten/pull/8011#discussion_r1853234409
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -219,6 +216,7 @@ object MetricsUtil extends Logging {
})
mutNode.updater match {
+ case MetricsUpdater.None =>
Review Comment:
Are we sure about this?
The code is likely something done by `MetricsUpdater.Todo`. I remember
`MetricsUpdater.Todo` and `MetricsUpdater.None` don't share the same semantic.
Did you check the UI? Are all the metrics still normal with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
