zml1206 commented on code in PR #8011:
URL: https://github.com/apache/incubator-gluten/pull/8011#discussion_r1853243739
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -219,6 +216,7 @@ object MetricsUtil extends Logging {
})
mutNode.updater match {
+ case MetricsUpdater.None =>
Review Comment:
It doesn't seem to make any difference whether to add it or not.
Theoretically, the size of None's operatorMetrics is 0, and a judgment
safety point is added.
Also, I didn't find any UI anomalies.
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -219,6 +216,7 @@ object MetricsUtil extends Logging {
})
mutNode.updater match {
+ case MetricsUpdater.None =>
Review Comment:
I thought about it carefully later, and I should remove it, which can help
us distinguish whether None is set incorrectly. If an
UnsupportedOperationException is thrown later, it means that it should not be
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
