zhztheplayer commented on code in PR #8011:
URL: https://github.com/apache/incubator-gluten/pull/8011#discussion_r1853408564
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -219,6 +216,7 @@ object MetricsUtil extends Logging {
})
mutNode.updater match {
+ case MetricsUpdater.None =>
Review Comment:
I see. My impressions about this part of code is:
* When `registerEmptyRelToOperator` is called, a fake operator creation is
actually emulated so `MetricsUpdator.Todo` should be considered
* When `child.asInstanceOf[TransformSupport].transform(context)` is used,
`MetricsUpdator.None` should be considered
Would you like to check whether the two rule apply?
And if we no longer need `MetricsUpdater.None`, we can just remove this type
of metrics updater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
