zhztheplayer commented on code in PR #8011:
URL: https://github.com/apache/incubator-gluten/pull/8011#discussion_r1855870807
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala:
##########
@@ -61,7 +61,9 @@ abstract class FilterExecTransformerBase(val cond:
Expression, val input: SparkP
case _ => false
}
- override def metricsUpdater(): MetricsUpdater = if (getRemainingCondition ==
null) {
+ override def isLoop: Boolean = getRemainingCondition == null
Review Comment:
s/isLoop/isNoop/
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ExpandExecTransformer.scala:
##########
@@ -48,7 +48,9 @@ case class ExpandExecTransformer(
AttributeSet.fromAttributeSets(projections.flatten.map(_.references))
}
- override def metricsUpdater(): MetricsUpdater = if (projections == null ||
projections.isEmpty) {
+ override def isLoop: Boolean = projections == null || projections.isEmpty
Review Comment:
s/isLoop/isNoop/
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/SortExecTransformer.scala:
##########
@@ -44,7 +44,9 @@ case class SortExecTransformer(
@transient override lazy val metrics =
BackendsApiManager.getMetricsApiInstance.genSortTransformerMetrics(sparkContext)
- override def metricsUpdater(): MetricsUpdater = if (sortOrder == null ||
sortOrder.isEmpty) {
+ override def isLoop: Boolean = sortOrder == null || sortOrder.isEmpty
Review Comment:
s/isLoop/isNoop/
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/WindowExecTransformer.scala:
##########
@@ -51,9 +51,9 @@ case class WindowExecTransformer(
@transient override lazy val metrics =
BackendsApiManager.getMetricsApiInstance.genWindowTransformerMetrics(sparkContext)
- override def metricsUpdater(): MetricsUpdater = if (
- windowExpression == null || windowExpression.isEmpty
- ) {
+ override def isLoop: Boolean = windowExpression == null ||
windowExpression.isEmpty
Review Comment:
s/isLoop/isNoop/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
