Yohahaha commented on code in PR #8380:
URL: https://github.com/apache/incubator-gluten/pull/8380#discussion_r1912593678
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -558,6 +558,18 @@ std::unordered_map<std::string, std::string>
WholeStageResultIterator::getQueryC
configs[velox::core::QueryConfig::kSparkLegacyDateFormatter] = "false";
}
+ const auto setIfExists = [&](const std::string& glutenKey, const
std::string& veloxKey) {
Review Comment:
if this func is common, should we declare it as static member function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
