jinchengchenghh commented on code in PR #8380:
URL: https://github.com/apache/incubator-gluten/pull/8380#discussion_r1912599974
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -558,6 +558,18 @@ std::unordered_map<std::string, std::string>
WholeStageResultIterator::getQueryC
configs[velox::core::QueryConfig::kSparkLegacyDateFormatter] = "false";
}
+ const auto setIfExists = [&](const std::string& glutenKey, const
std::string& veloxKey) {
Review Comment:
Yes, good suggestion, I think the config needs to do the refactor, now if
the config not set by java side, we will set a default value of velox config to
velox query config, we should change to not set the config.
If velox config default value is changed, we can change automatic with them
if we don't have different default value with velox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
