zhztheplayer commented on code in PR #8380:
URL: https://github.com/apache/incubator-gluten/pull/8380#discussion_r1917781901
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -1206,6 +1207,24 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::constructValueStreamNode(
return node;
}
+core::PlanNodePtr SubstraitToVeloxPlanConverter::constructValuesNode(
+ const ::substrait::ReadRel& readRel,
+ int32_t streamIdx) {
+ std::vector<RowVectorPtr> values;
+ VELOX_CHECK_LT(streamIdx, inputIters_.size(), "Could not find stream index
{} in input iterator list.", streamIdx);
+ const auto iterator = inputIters_[streamIdx];
+ while (iterator->hasNext()) {
+ auto cb = VeloxColumnarBatch::from(defaultLeafVeloxMemoryPool().get(),
iterator->next());
Review Comment:
Is the memory managed by Spark? Given that `defaultLeafVeloxMemoryPool` is
global.
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -51,6 +51,14 @@ const std::string kWriteIOTime = "writeIOTime";
// others
const std::string kHiveDefaultPartition = "__HIVE_DEFAULT_PARTITION__";
+std::string getQueryId(const std::unordered_map<std::string, std::string>&
confMap) {
+ auto it = confMap.find(kQueryTraceQueryId);
+ if (it != confMap.end()) {
+ return it->second;
+ }
+ return "";
+}
+
Review Comment:
A little bit confused with the empty query ID. Can we always give a
meaningful ID to Velox?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
