jinchengchenghh commented on code in PR #8380:
URL: https://github.com/apache/incubator-gluten/pull/8380#discussion_r1921931127
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -51,6 +51,14 @@ const std::string kWriteIOTime = "writeIOTime";
// others
const std::string kHiveDefaultPartition = "__HIVE_DEFAULT_PARTITION__";
+std::string getQueryId(const std::unordered_map<std::string, std::string>&
confMap) {
+ auto it = confMap.find(kQueryTraceQueryId);
+ if (it != confMap.end()) {
+ return it->second;
+ }
+ return "";
+}
+
Review Comment:
The queryId concept is not really query id, it is velox query id, not Spark
queryId, now one query for one task, so I think we can use the same name with
task name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
