jinchengchenghh commented on code in PR #8380:
URL: https://github.com/apache/incubator-gluten/pull/8380#discussion_r1923239106
##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -2288,4 +2294,48 @@ object GlutenConfig {
.doc("If enabled, gluten will not offload scan when encrypted parquet
files are detected")
.booleanConf
.createWithDefault(false)
+
+ val QUERY_TRACE_ENABLED =
buildConf("spark.gluten.sql.columnar.backend.velox.queryTraceEnabled")
+ .doc("Enable query tracing flag.")
+ .internal()
+ .booleanConf
+ .createWithDefault(false)
+
+ val QUERY_TRACE_DIR =
buildConf("spark.gluten.sql.columnar.backend.velox.queryTraceDir")
+ .doc("Base dir of a query to store tracing data.")
Review Comment:
This config is only used in internal, user will not set it by this config
name, because we need to enable query trace in benchmark, so user set it by
FLAGS_XX in benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]