duanmeng commented on PR #8380: URL: https://github.com/apache/incubator-gluten/pull/8380#issuecomment-2598205558
> The GenericBenchmark is frequently used by us CC @JkSelf , it is really usefully for debug in cpp side, we can use vscode to do step-by-step debug. And query trace is widely used in Velox to do correctness verification and performance profiling, so I think we need to enable it in Gluten. and with this optimization [#8380 (comment)](https://github.com/apache/incubator-gluten/pull/8380#issuecomment-2594652831), we could drop the ValueStreamNode to ValusNode replace. @zhztheplayer As discussed with @jinchengchenghh offline, we could add simple `ValueStreamNode` serde methods that serialize only `id` and `output type` and create a `ValueStreamNode` with empty `ResultIterator`. Because we do not need to trace the `ValueStreamNode`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
