taiyang-li commented on code in PR #8558:
URL: https://github.com/apache/incubator-gluten/pull/8558#discussion_r1951880003
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -97,7 +97,10 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
if (udf.udfName.isEmpty) {
throw new GlutenNotSupportException("UDF name is not found!")
}
- val substraitExprName = UDFMappings.scalaUDFMap.get(udf.udfName.get)
+ var substraitExprName = UDFMappings.scalaUDFMap.get(udf.udfName.get)
Review Comment:
collapsedFunctionsMap和udf有什么关系？看起来逻辑上没必要耦合在一块，最好能解耦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
