KevinyhZou commented on code in PR #8558:
URL: https://github.com/apache/incubator-gluten/pull/8558#discussion_r1951880546
##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -839,6 +839,13 @@ object GlutenConfig {
.stringConf
.createWithDefault("")
+ val GLUTEN_SUPPORTED_COLLAPSED_FUNCTIONS =
+ buildConf("spark.gluten.sql.supported.collapseNestedFunctions")
+ .internal()
+ .doc("Collapse nested functions as one for optimization.")
+ .stringConf
+ .createWithDefault("get_struct_field,get_json_object");
Review Comment:
`and`, `or` has conflict with `ReusedExchange` optimize rule, it would make
the rule not take effect at some suitation, about 3 ut failed in the ci:
https://opencicd.kyligence.com/job/gluten/job/gluten-ci/14509/consoleText. so I
disable them by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]