taiyang-li commented on code in PR #8558:
URL: https://github.com/apache/incubator-gluten/pull/8558#discussion_r1951890369
##########
cpp-ch/local-engine/Functions/SparkFunctionGetJsonObject.h:
##########
@@ -462,8 +463,55 @@ class GetJsonObjectImpl
static size_t getNumberOfIndexArguments(const DB::ColumnsWithTypeAndName &
arguments) { return arguments.size() - 1; }
+ bool insertResultToColumn(DB::IColumn & dest, typename JSONParser::Element
& root, std::vector<std::shared_ptr<DB::GeneratorJSONPath<JSONParser>>> &
generator_json_paths, size_t & json_path_pos) const
Review Comment:
@lgbo-ustc pls review this change related to `get_json_object`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
