ArnavBalyan commented on code in PR #8640: URL: https://github.com/apache/incubator-gluten/pull/8640#discussion_r1997864438
########## cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc: ########## @@ -242,6 +242,9 @@ bool SubstraitToVeloxPlanValidator::isAllowedCast(const TypePtr& fromType, const // 3. Timestamp to most categories except few supported types is not allowed. // 4. Certain complex types are not allowed. + auto fromKind = fromType->kind(); + auto toKind = toType->kind(); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
