jackylee-ch commented on code in PR #8640:
URL: https://github.com/apache/incubator-gluten/pull/8640#discussion_r1998113960


##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -100,6 +100,7 @@ class VeloxTestSettings extends BackendTestSettings {
     .exclude(
       "Process Infinity, -Infinity, NaN in case insensitive manner" // +inf 
not supported in folly.
     )
+    .exclude("cast from timestamp II") // Rewrite test for Gluten

Review Comment:
   We need a comment to explain why we exclude this test. `Rewrite test for 
Gluten` semms not a suitable reason. is it work defferently with velox?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to