ArnavBalyan commented on code in PR #8640:
URL: https://github.com/apache/incubator-gluten/pull/8640#discussion_r1998461822
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -100,6 +100,7 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude(
"Process Infinity, -Infinity, NaN in case insensitive manner" // +inf
not supported in folly.
)
+ .exclude("cast from timestamp II") // Rewrite test for Gluten
Review Comment:
Hi @jackylee-ch have added the reason and fix here
https://github.com/apache/incubator-gluten/pull/9011. We are running the wrong
tests, once it's merged I'll enable/re-write for Gluten. With ANSI on, Spark
had additional tests leading to overflow but Gluten does not support ANSI mode
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
