PHILO-HE commented on code in PR #9024:
URL: https://github.com/apache/incubator-gluten/pull/9024#discussion_r2004901714
##########
.github/workflows/velox_backend.yml:
##########
@@ -638,6 +638,12 @@ jobs:
with:
name: test-report-spark32
path: '**/surefire-reports/TEST-*.xml'
+ - name: Upload unit tests log files
+ if: ${{ !success() }}
+ uses: actions/upload-artifact@v4
+ with:
+ name: unit-tests-log-spark32
Review Comment:
Suggest to simply reference the job name, e.g., `name: "${{ github.job
}}-test-log"`. Ditto for other places.
##########
pom.xml:
##########
@@ -1371,6 +1371,9 @@
<testFailureIgnore>${maven.test.failure.ignore}</testFailureIgnore>
<junitxml>.</junitxml>
<argLine>${argLine} ${extraJavaTestArgs}</argLine>
+ <systemProperties>
+
<log4j.configurationFile>file:src/test/resources/log4j2.properties</log4j.configurationFile>
Review Comment:
ok. Please note some modules' structure is like
`src-iceberg/test/resources/...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
