yaooqinn commented on code in PR #9024:
URL: https://github.com/apache/incubator-gluten/pull/9024#discussion_r2004893269
##########
pom.xml:
##########
@@ -1371,6 +1371,9 @@
<testFailureIgnore>${maven.test.failure.ignore}</testFailureIgnore>
<junitxml>.</junitxml>
<argLine>${argLine} ${extraJavaTestArgs}</argLine>
+ <systemProperties>
+
<log4j.configurationFile>file:src/test/resources/log4j2.properties</log4j.configurationFile>
Review Comment:
I haven't tested w/ a single root `log4j2.properties`, so I'm not sure
whether it will work or not. But copying it module by module is also a good
practice that follows the behavior of the Spark project. It allows us to
customize each copy for different logging behaviors of different modules, or w/
different log4j2 dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
