PHILO-HE commented on code in PR #9024:
URL: https://github.com/apache/incubator-gluten/pull/9024#discussion_r2004958216
##########
.github/workflows/velox_backend.yml:
##########
@@ -638,6 +638,12 @@ jobs:
with:
name: test-report-spark32
path: '**/surefire-reports/TEST-*.xml'
+ - name: Upload unit tests log files
+ if: ${{ !success() }}
+ uses: actions/upload-artifact@v4
+ with:
+ name: unit-tests-log-spark32
Review Comment:
I would recommend to change golden file name also.
It' just for well distinguishing which job produces the file. It's also for
better maintenance, especially when we add more test job derived from an
existing one. I note `golden-files-spark35` was unexpected both used as golden
file name for JDK 8 and 17 test job, which is a small mistake easy to make.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
