ArnavBalyan commented on code in PR #9394:
URL: https://github.com/apache/incubator-gluten/pull/9394#discussion_r2055243443
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -232,6 +232,18 @@ bool SubstraitToVeloxPlanValidator::validateScalarFunction(
return true;
}
+bool isValidArrayCast(const TypePtr& fromType, const TypePtr& toType) {
+ const auto& fromElem = fromType->asArray().elementType();
Review Comment:
Removed
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -232,6 +232,18 @@ bool SubstraitToVeloxPlanValidator::validateScalarFunction(
return true;
}
+bool isValidArrayCast(const TypePtr& fromType, const TypePtr& toType) {
Review Comment:
Updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
