ArnavBalyan commented on code in PR #9394:
URL: https://github.com/apache/incubator-gluten/pull/9394#discussion_r2055244693
##########
gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -626,6 +626,10 @@ class ClickHouseTestSettings extends BackendTestSettings {
.exclude("SPARK-36924: Cast YearMonthIntervalType to IntegralType")
.exclude("SPARK-36924: Cast IntegralType to YearMonthIntervalType")
.exclude("Cast should output null for invalid strings when ANSI is not
enabled.")
+ .exclude("cast array from IntegerType to StringType")
+ .exclude("cast array from DoubleType to StringType")
+ .exclude("cast array from BooleanType to StringType")
+ .exclude("cast array from DateType to StringType")
Review Comment:
This change does not touch CH, but `DoubleType to StringType` fails in the
Clickhouse CI due to some already existing issue in CH array cast. Excluded
this test since the change is only touching Velox code thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
