ArnavBalyan commented on code in PR #9394:
URL: https://github.com/apache/incubator-gluten/pull/9394#discussion_r2060646371
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -232,6 +232,17 @@ bool SubstraitToVeloxPlanValidator::validateScalarFunction(
return true;
}
+bool isSupportedArrayCast(const TypePtr& fromType, const TypePtr& toType) {
Review Comment:
Agreed I was expecting the Spark UTs to cover it. Have added defensive
checks to limit the from/to. Also added UTs for the supported casts. In most
cases velox array goes through applyPeeled and same flow for individual
elements. Limited the cast patterns and added UTs in addition to Spark UTs
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
