acvictor commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2840935783
> > even if collect list is made imperative and we retain ObjectHashAggregate in the initial plan, I believe the sort clause will still be removed as part of the local sort elimination rules and the result order does not match. > > [@acvictor](https://github.com/acvictor) We also need to change EliminateLocalSort rule to allow the removal of the local sort only when the sort aggregation is transformed into a hash aggregation. @NEUpanning can you please elaborate? The sort aggregate is no longer present. However does the fact that docs say that the function is non-deterministic because the order of collected results depends on the order of the rows which may be non-deterministic after a shuffle imply that ordering cannot be guaranteed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
