NEUpanning commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2841065356
> can you please elaborate? The sort aggregate is no longer present. For now, EliminateLocalSort will remove local sort regardless hash agg transformer is transformed from sort agg. https://github.com/apache/incubator-gluten/blob/main/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/EliminateLocalSort.scala#L37 > the function is non-deterministic because the order of collected results depends on the order of the rows which may be non-deterministic after a shuffle imply that ordering cannot be guaranteed? In this case, this is no shuffle between partial agg and final agg. So the result should be deterministic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
