acvictor commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2846842284
> > can you please elaborate? The sort aggregate is no longer present. > > For now, EliminateLocalSort will remove local sort regardless hash agg transformer is transformed from sort agg. https://github.com/apache/incubator-gluten/blob/main/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/EliminateLocalSort.scala#L37 > @NEUpanning can you please help review the change for hash aggregate? https://github.com/apache/incubator-gluten/pull/9473? I see that the Sort before Project in the example case still gets eliminated however. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
