nimesh1601 commented on PR #10267: URL: https://github.com/apache/incubator-gluten/pull/10267#issuecomment-3130589017
@FelixYBW, all tests of GlutenTryEvalSuite are already included. No tests were excluded. I checked [VeloxTestSettings.scala](https://github.com/apache/incubator-gluten/blob/main/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala#L191). In the test logs, I can see ``` 2025-07-29T00:27:07.1611958Z - try_divide 2025-07-29T00:27:07.2195540Z 'try_subtract' offload to gluten 2025-07-29T00:27:07.2196030Z - try_subtract 2025-07-29T00:27:07.3096229Z 'try_multiply' offload to gluten 2025-07-29T00:27:07.3098568Z - try_multiply 2025-07-29T00:27:07.3701933Z 'Throw exceptions from children' offload to gluten 2025-07-29T00:27:07.3702425Z - Throw exceptions from children 2025-07-29T00:27:07.3734960Z 00:27:07.373 WARN org.apache.spark.sql.catalyst.expressions.GlutenTryEvalSuite: ``` But while testing for production workload, I also removed the ANSI fallback check in [VeloxRuleApi.scala](https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala#L68) Current Test failures seems unrelated `SPARK-19059: read file based table whose name starts with underscore *** FAILED ***.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
