nimesh1601 commented on code in PR #10267:
URL:
https://github.com/apache/incubator-gluten/pull/10267#discussion_r2238487461
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -115,10 +115,6 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
right: ExpressionTransformer,
original: TryEval,
checkArithmeticExprName: String): ExpressionTransformer = {
- if (SparkShimLoader.getSparkShims.withAnsiEvalMode(original.child)) {
Review Comment:
@zhli1142015 I think it still won't get offloaded to Velox as we have a
fallback rule for ANSI in
[VeloxRuleApi.scala](https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala#L68).
Even while testing in production, I needed to remove this rule, so testing by
query might not work. Should I add a config that skips this fallback, maybe
something like spark.gluten.sql.ansi.forceEnabled ? This will also allow other
ansi supported operators to work with ansi too. wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
