zhli1142015 commented on code in PR #10267:
URL:
https://github.com/apache/incubator-gluten/pull/10267#discussion_r2238430439
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -115,10 +115,6 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
right: ExpressionTransformer,
original: TryEval,
checkArithmeticExprName: String): ExpressionTransformer = {
- if (SparkShimLoader.getSparkShims.withAnsiEvalMode(original.child)) {
Review Comment:
I assume that by removing this conditional check, the original try_xx
function—which used to fall back—will now be offloaded to Velox. Could you add
corresponding tests? Something like the example below, to make sure they
actually get offloaded to Velox.
https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala#L302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
