PHILO-HE commented on code in PR #10564:
URL:
https://github.com/apache/incubator-gluten/pull/10564#discussion_r2305923697
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -189,6 +189,9 @@ function setup_linux {
;;
esac
elif [[ "$LINUX_DISTRIBUTION" == "openEuler" ]]; then
+ # this is workaround for gcc-12.3.1
+ #
https://github.com/facebookincubator/velox/blob/b263d9dd8b8910dc642d8fdb0c0adee4b2a1fb29/CMakeLists.txt#L433
+ sed -i "s|no-unknown-warning-option|no-unknown-warning-option
-Wno-restrict|g" ../../src/build_velox.sh
Review Comment:
According to the link below commented in Velox, it seems the gcc community
is retargeting the bugs to GCC 12.5. Therefore, I am wondering if we can just
submit a Velox PR to include 12.3.x and even 12.4.x in that check of
CMakeLists.txt. Assume this issue is not limited to openEuler.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
