zhouyuan commented on code in PR #10564:
URL:
https://github.com/apache/incubator-gluten/pull/10564#discussion_r2306566398
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -189,6 +189,9 @@ function setup_linux {
;;
esac
elif [[ "$LINUX_DISTRIBUTION" == "openEuler" ]]; then
+ # this is workaround for gcc-12.3.1
+ #
https://github.com/facebookincubator/velox/blob/b263d9dd8b8910dc642d8fdb0c0adee4b2a1fb29/CMakeLists.txt#L433
+ sed -i "s|no-unknown-warning-option|no-unknown-warning-option
-Wno-restrict|g" ../../src/build_velox.sh
Review Comment:
@PHILO-HE @kevinw66 could we land this fix on Gluten side first? My
intention is to fix the coming 1.5 release.
I will also submit the patch to Velox, once it's merged we could revert this
workaround
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]