PHILO-HE commented on code in PR #10564:
URL: 
https://github.com/apache/incubator-gluten/pull/10564#discussion_r2306073590


##########
ep/build-velox/src/get_velox.sh:
##########
@@ -189,6 +189,9 @@ function setup_linux {
       ;;
     esac
   elif [[ "$LINUX_DISTRIBUTION" == "openEuler" ]]; then
+    # this is workaround for gcc-12.3.1
+    # 
https://github.com/facebookincubator/velox/blob/b263d9dd8b8910dc642d8fdb0c0adee4b2a1fb29/CMakeLists.txt#L433
+    sed -i "s|no-unknown-warning-option|no-unknown-warning-option 
-Wno-restrict|g" ../../src/build_velox.sh

Review Comment:
   They look similar. If 12.4 is not confirmed, I think we can just include 
12.3 in the check at Velox side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to