LuciferYang opened a new pull request, #12574:
URL: https://github.com/apache/gluten/pull/12574
### What changes were proposed in this pull request?
Follow-up to the Spark 3.2 cleanup series (#12525, #12541, #12550, and the
open #12543 / #12548). This drops the `testWithMinSparkVersion("...", "3.2")`
guard from 12 test callsites: the guard is always true on any currently
supported Spark profile (3.3+), so the wrapper is replaced with a plain
`test("...")`.
**Callsites converted**
| File | Sites |
|---|---|
| `gluten-ut/test/.../GlutenExpressionMappingSuite.scala` | L50, L71 |
| `gluten-hudi/.../HudiSuite.scala` | L41, L68, L114 |
| `backends-velox/.../VeloxColumnarCacheSuite.scala` | L90 |
| `gluten-delta/.../DeltaSuite.scala` | L70, L327, L346, L366, L443, L481 |
The `DeltaSuite.scala:69` comment "`NameMapping is supported in Delta 2.0
(related to Spark3.2.0)`" is also dropped — it was pinned to the same 3.2 guard.
**Not touched**
The `testWithMinSparkVersion` helper itself
(`gluten-substrait/.../GlutenQueryTest.scala:132`) is kept — it is still used
at 60+ other sites with `3.4` / `3.5` / `4.0` `minVersion` arguments, which
remain legitimate on the currently supported Spark matrix.
No behavior change on any supported Spark version.
### How was this patch tested?
- `./build/mvn -Pbackends-velox -Pspark-3.5 -Pspark-ut -pl :gluten-ut-test
-am test-compile -DskipTests`: SUCCESS
- `./build/mvn -Pbackends-velox -Pspark-3.5 -Pdelta -pl :gluten-delta -am
test-compile -DskipTests`: SUCCESS
- `./build/mvn -Pbackends-velox -Pspark-3.5 -Phudi -pl :gluten-hudi -am
test-compile -DskipTests`: SUCCESS
- `./build/mvn -Pbackends-velox -Pspark-3.5 -pl backends-velox -am
test-compile -DskipTests`: SUCCESS
- `./dev/format-scala-code.sh`: no additional diff
- Repo-wide `grep -rn 'testWithMinSparkVersion.*"3\.[012]"'`: 0 remaining
occurrences after the change
- Verified no test-name collisions introduced in any of the 4 touched suites
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude claude-opus-4-7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
