LuciferYang commented on code in PR #12574:
URL: https://github.com/apache/gluten/pull/12574#discussion_r3612882241
##########
gluten-delta/src/test/scala/org/apache/gluten/execution/DeltaSuite.scala:
##########
@@ -66,8 +66,7 @@ abstract class DeltaSuite extends WholeStageTransformerSuite {
}
}
- // NameMapping is supported in Delta 2.0 (related to Spark3.2.0)
- testWithMinSparkVersion("column mapping mode = name", "3.2") {
+ test("column mapping mode = name") {
Review Comment:
Good catch — my single-line `grep 'testWithMinSparkVersion.*"3.2"'` missed
exactly the 6 sites you pointed out, all spanning 3 lines each inside
`Seq("name", "id").foreach` column-mapping loops in DeltaSuite (L112 / L155 /
L187 / L222 / L249 / L274).
Fixed in d4716dfc6 — converted all 6 to plain `test(...)`. After the
follow-up commit, a multi-line `awk` scan finds zero remaining
`testWithMinSparkVersion(..., "3.[012]")` sites anywhere in the repo. Updated
total is 18 sites (6 more than the description states); I'll amend the PR
description as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
