Copilot commented on code in PR #12574:
URL: https://github.com/apache/gluten/pull/12574#discussion_r3612816175
##########
gluten-delta/src/test/scala/org/apache/gluten/execution/DeltaSuite.scala:
##########
@@ -66,8 +66,7 @@ abstract class DeltaSuite extends WholeStageTransformerSuite {
}
}
- // NameMapping is supported in Delta 2.0 (related to Spark3.2.0)
- testWithMinSparkVersion("column mapping mode = name", "3.2") {
+ test("column mapping mode = name") {
Review Comment:
The PR description claims there are no remaining
`testWithMinSparkVersion(..., "3.[012]")` call sites after this change, but
`DeltaSuite` still contains several `testWithMinSparkVersion(..., "3.2")`
guards (e.g. around `Seq("name", "id").foreach { ...
testWithMinSparkVersion(..., "3.2") { ... } }`). The repo-wide grep shown in
the description likely missed these because the `"3.2"` argument is on a
different line. Consider converting these remaining `"3.2"` guards to plain
`test(...)` as well (or update the PR description/testing note to reflect the
remaining multi-line occurrences).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
