Copilot commented on code in PR #12605:
URL: https://github.com/apache/gluten/pull/12605#discussion_r3922789827
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -670,6 +670,9 @@ std::unordered_map<std::string, std::string>
WholeStageResultIterator::getQueryC
configs[SparkQueryConfig::qualify(SparkQueryConfig::kJsonIgnoreNullFields)] =
std::to_string(veloxCfg_->get<bool>(kSparkJsonIgnoreNullFields, true));
+
configs[SparkQueryConfig::qualify(SparkQueryConfig::kDecimalToFloatHighPrecisionCastEnabled)]
= std::to_string(
+ veloxCfg_->get<bool>(kDecimalToFloatHighPrecisionCastEnabled,
kDecimalToFloatHighPrecisionCastEnabledDefault));
Review Comment:
Keep this config assignment formatted consistently with nearby
SparkQueryConfig entries (break after '='). This helps readability and avoids
clang-format churn in a file that otherwise wraps these long keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
