rui-mo commented on code in PR #12605:
URL: https://github.com/apache/gluten/pull/12605#discussion_r3924060800
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -459,6 +459,115 @@ class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ // Gluten's checkAnswer accepts any two doubles within 1e-5 of each other,
which is far
+ // wider than the precision loss under test here: 214.4 and
214.39999999999998 compare
+ // equal. Comparing the rendered values instead keeps the assertion exact.
+ private def assertRendersLikeVanilla(sqlText: String, glutenRows:
Array[Row]): Unit = {
Review Comment:
nit: can we use a name that clarifies how the comparison is strengthened,
rather than saying “like vanilla”?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
