Copilot commented on code in PR #12771:
URL: https://github.com/apache/gluten/pull/12771#discussion_r3924488566
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -120,7 +120,6 @@ class VeloxTestSettings extends BackendTestSettings {
// Excluded in favour of the GlutenCastWithAnsiOffSuite rewrite, which
drops the Long.MinValue
// assertion: collect() -> toJavaTimestamp ->
rebaseGregorianToJulianMicros overflows.
.exclude("cast from timestamp II")
- .exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
Review Comment:
PR description says the exclusion is removed across spark33/34/35/40/41 and
that `ep/build-velox/src/get-velox.sh` sets `UPSTREAM_VELOX_PR_ID="18502"`. In
this branch, there is no `gluten-ut/spark33` shim directory, and `get-velox.sh`
still has `UPSTREAM_VELOX_PR_ID=""` (so CI won’t actually apply the Velox PR
patch as described). Please either (a) update the PR description/testing
section to match what the diff actually changes, or (b) include the missing
shim/script updates so the re-enabled test is validated against the intended
Velox fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
