rdtr commented on code in PR #13184:
URL: https://github.com/apache/gluten/pull/13184#discussion_r4252410459
##########
backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala:
##########
@@ -1649,12 +1649,17 @@ class MiscOperatorSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSpa
}
test("Support multi-children count with row construct") {
- runQueryAndCompare(
- """
- |select l_orderkey, count(distinct l_partkey, l_comment),
corr(l_partkey, l_partkey+1)
- |from lineitem group by l_orderkey
- |""".stripMargin
- )(df => checkFallbackOperators(df, 0))
+ // Spark before 4.3 (SPARK-58213) throws DIVIDE_BY_ZERO for corr on a
column with zero variance
+ // in ANSI mode, while Velox returns NULL as Spark 4.3 does. Run with ANSI
mode disabled until
+ // the minimum supported Spark version includes the fix.
Review Comment:
Created #13255 and linked it from the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
