rdtr commented on code in PR #13184:
URL: https://github.com/apache/gluten/pull/13184#discussion_r4252414996
##########
gluten-substrait/src/test/scala/org/apache/gluten/execution/GlutenQueryComparisonTest.scala:
##########
@@ -72,6 +74,32 @@ abstract class GlutenQueryComparisonTest extends
GlutenQueryTest {
cache)
}
+ /**
+ * Like `runQueryAndCompare`, but in ANSI mode also accepts a query that
fails on vanilla Spark,
+ * which happens when ANSI mode rejects its input (for example, a malformed
string cast to a
+ * number). In that case, checks that Gluten fails too.
+ */
+ protected def runQueryAndCompareOrBothFail(
Review Comment:
Good idea, renamed it to `runQueryAndCheck` (and updated the PR description).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
