rdtr commented on PR #13184: URL: https://github.com/apache/gluten/pull/13184#issuecomment-6132813717
> Thanks for your work. Looks good overall. > > "The ANSI CI (velox_backend_ansi.yml) runs the backends-velox tests with ANSI mode enabled and ANSI fallback disabled" > > I feel that the ANSI CI is too redundant since it also runs many tests that are not related to ANSI. Using explicit ANSI on and off on those related tests should be better, which needs some efforts for identifying them. This thought is not directly related to this PR. Perhaps, we can consider this in the future once ANSI support is clearer to us. Thanks for the review! I agree that running every backends-velox test in ANSI mode is heavy. Turning ANSI mode on and off explicitly in the related tests sounds better once ANSI support settles, and I'm happy to help with it then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
