wud-if commented on PR #13375:
URL: https://github.com/apache/gluten/pull/13375#issuecomment-6462090947
@ggjh-159 Thanks for the review! Pushed dc0bc10 (plus 5b993ca for the
velox-side review follow-up on scalar-only coverage):
- toNullVariant: added the missing DATE case plus INTERVAL_SECOND and SYMBOL
(all fall through to the same null-accepting VarCharValue carrier), so
IFNULL(date_col, NULL) / IFNULL(NULL, date_col) now plan fine. The null-literal
test covers DATE, SYMBOL and a second-interval null literal; interval types are
built via createSqlIntervalType(SqlIntervalQualifier) since
createSqlType(INTERVAL_SECOND) is rejected by Calcite.
- Spotless: applied; the stray blank line is gone.
- Also note: IFNULL now uses ScalarOnlyRexCallConverter —
non-scalar operands (BINARY/ARRAY/MAP/ROW) are rejected at the converter level
so the planner falls back to the native operator, matching the scalar-only
velox registrations raised in the velox-side review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
