wud-if commented on PR #13375: URL: https://github.com/apache/gluten/pull/13375#issuecomment-6490548479
@KevinyhZou Thanks for the correction — you're right, this is plan-time fail-loud, not a fallback: getConverter throws when no converter matches and StreamExecCalc does not catch it, so the job fails at plan translation. Pushed cc69043 rewording all three spots as suggested: - ScalarOnlyRexCallConverter / TypeUtils: operands (BINARY, ARRAY, MAP, ROW) are rejected so conversion fails loudly at planning time instead of failing at runtime with an unresolved velox signature. - RexNodeConverter: the typed-null serde comment now reflects the current state — velox4j emits an explicit "value": null via @JsonInclude(ALWAYS), and the velox serde accepts both an explicit null and an absent member. The PR description is updated accordingly as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
