luis4a0 commented on code in PR #13282:
URL: https://github.com/apache/gluten/pull/13282#discussion_r4551341540


##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -127,6 +127,15 @@ bool SubstraitToVeloxPlanValidator::validateRound(
     return false;
   }
 
+  const auto& scale = arguments[1].value().literal();
+  if (scale.has_null() && scale.null().has_i32()) {
+    const auto& valueType = params[0]->type();
+    if (!valueType->isDecimal() &&
+        (valueType->isTinyint() || valueType->isSmallint() || 
valueType->isInteger() || valueType->isBigint())) {
+      return true;
+    }
+  }

Review Comment:
   Fixed in verified head 
https://github.com/luis4a0/gluten/commit/0a56fafb48bf3a191902f75d8b7608cfeccb7d2b.
 `validateRound` now rejects an empty or null converted argument before 
accessing `params[0]`, and `SparkFunctionTest.integralRoundScaleValidation` 
includes a missing-value regression.



##########
ep/build-velox/src/get-velox.sh:
##########
@@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON
 ENABLE_ENHANCED_FEATURES=OFF
 
 # Developer use only for testing Velox PR.
-UPSTREAM_VELOX_PR_ID=""
+UPSTREAM_VELOX_PR_ID="19480"

Review Comment:
   Resolved by the current-main refresh at 
https://github.com/luis4a0/gluten/commit/0a56fafb48bf3a191902f75d8b7608cfeccb7d2b.
 The effective PR no longer changes `get-velox.sh`; Gluten uses its normal 
`dft-2026_11_10` pin with no hard-coded PR or downloaded patch.



##########
docs/backends/velox/velox-backend-scalar-function-support.md:
##########
@@ -297,7 +297,7 @@ The status applies to `spark.sql.ansi.enabled=false`. When 
ANSI mode is enabled,
 | randn             | Randn                  | S        |                |
 | random            | Rand                   | S        |                |
 | rint              | Rint                   | S        |                |
-| round             | Round                  | S        |                |
+| round             | Round                  | PS       | Integral scales in 
[0, 400] and NULL use upstream Velox. NULL scales skip child evaluation. 
Negative scales, scales outside [0, 400], and scales not folded to INTEGER 
literals fall back to Spark to preserve captured ANSI behavior. |

Review Comment:
   Fixed in verified head 
https://github.com/luis4a0/gluten/commit/0a56fafb48bf3a191902f75d8b7608cfeccb7d2b.
 The document now defines `S` as fully supported and `PS` as partially 
supported near the top.



##########
ep/build-velox/src/get-velox.sh:
##########
@@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON
 ENABLE_ENHANCED_FEATURES=OFF
 
 # Developer use only for testing Velox PR.
-UPSTREAM_VELOX_PR_ID=""
+UPSTREAM_VELOX_PR_ID="19480"

Review Comment:
   Resolved by the current-main refresh at 
https://github.com/luis4a0/gluten/commit/0a56fafb48bf3a191902f75d8b7608cfeccb7d2b.
 The effective PR no longer changes `get-velox.sh`; no upstream PR ID is 
configured.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to