luis4a0 commented on code in PR #13282: URL: https://github.com/apache/gluten/pull/13282#discussion_r4551344290
########## docs/backends/velox/velox-backend-scalar-function-support.md: ########## @@ -297,7 +297,7 @@ The status applies to `spark.sql.ansi.enabled=false`. When ANSI mode is enabled, | randn | Randn | S | | | random | Rand | S | | | rint | Rint | S | | -| round | Round | S | | +| round | Round | PS | Integral scales in [0, 400] and NULL use upstream Velox. NULL scales skip child evaluation. Negative scales, scales outside [0, 400], and scales not folded to INTEGER literals fall back to Spark to preserve captured ANSI behavior. | Review Comment: Fixed in verified head https://github.com/luis4a0/gluten/commit/0a56fafb48bf3a191902f75d8b7608cfeccb7d2b. The ROUND restriction cell is shortened to the supported scales, fallback cases, and debug bypass. ########## ep/build-velox/src/get-velox.sh: ########## @@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON ENABLE_ENHANCED_FEATURES=OFF # Developer use only for testing Velox PR. -UPSTREAM_VELOX_PR_ID="" +UPSTREAM_VELOX_PR_ID="19480" Review Comment: Done in verified head https://github.com/luis4a0/gluten/commit/0a56fafb48bf3a191902f75d8b7608cfeccb7d2b. Current Gluten main pins `dft-2026_11_10`, which contains the landed ROUND changes, so the effective PR drops all temporary Velox patches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
