matrei commented on code in PR #14668:
URL: https://github.com/apache/grails-core/pull/14668#discussion_r2058338340
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/CustomAutoTimestampSpec.groovy:
##########
@@ -41,19 +35,21 @@ class CustomAutoTimestampSpec extends GormDatastoreSpec {
r = RecordCustom.get(r.id)
then:"the custom lastUpdated and dateCreated are set"
- r.modified != null && r.modified < new Date()
- r.created != null && r.created < new Date()
+ r.modified != null
Review Comment:
I don't think the time checks are necessary to fulfill the contract of what
is tested.
That is why I removed it. Do you think I should add it back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
