matrei commented on code in PR #14668:
URL: https://github.com/apache/grails-core/pull/14668#discussion_r2058332064
##########
.github/workflows/gradle.yml:
##########
@@ -212,20 +213,18 @@ jobs:
with:
develocity-access-key: ${{ secrets.GRAILS_DEVELOCITY_ACCESS_KEY }}
- name: "📤 Publish Grails-Core Snapshot Artifacts"
- id: publish
env:
GRAILS_PUBLISH_RELEASE: 'false'
MAVEN_PUBLISH_URL: ${{ secrets.GRAILS_NEXUS_PUBLISH_SNAPSHOT_URL }}
MAVEN_PUBLISH_USERNAME: ${{ secrets.NEXUS_USER }}
MAVEN_PUBLISH_PASSWORD: ${{ secrets.NEXUS_PW }}
- run: >
- ./gradlew publish
+ run: ./gradlew publish
docs:
if: github.repository_owner == 'apache' && github.event_name == 'push'
- needs: [publish]
- runs-on: ubuntu-latest
+ needs: [ publish ]
+ runs-on: ubuntu-24.04
permissions:
- contents: write
+ contents: write # TODO: Comment why this is needed
Review Comment:
OK, so I can remove it?
I also see some `contents: read # to fetch code (actions/checkout)`
These should not be necessary, should they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
