jdaugherty commented on code in PR #14668:
URL: https://github.com/apache/grails-core/pull/14668#discussion_r2058738512


##########
grails-gradle/plugins/src/e2eTest/resources/publish-projects/legacy-apply/child-project-with-unrelated-parent/build.gradle:
##########
@@ -20,6 +20,7 @@
 buildscript {
     repositories {
         maven { url "${System.getenv('LOCAL_MAVEN_PATH')}" }
+        mavenCentral()

Review Comment:
   We should remove the grails repo & the apache repo.  They shouldnt' be 
needed.  the purpose of these tests were to have a minimum build file (so just 
include groovy as a minimum dependency), and the gradle plugin should be 
substituted by the gradle test kit.



##########
grails-gradle/plugins/src/e2eTest/resources/publish-projects/legacy-apply/child-project-with-unrelated-parent/build.gradle:
##########
@@ -20,6 +20,7 @@
 buildscript {
     repositories {
         maven { url "${System.getenv('LOCAL_MAVEN_PATH')}" }
+        mavenCentral()

Review Comment:
   We should remove the grails repo & the apache repo.  They shouldnt' be 
needed.  the purpose of these tests were to have a minimum build file (so just 
include groovy as a minimum dependency), and the gradle plugin should be 
substituted by the gradle test kit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to